Don't allow choir members to listen to others' solo parts

[glynnbird]

Comment from real-world choir user:

As you might have noticed I recorded a part in the bass section but I have now removed that recording.

I feel a bit uneasy that anybody can listen to my recording. I am not a particularly good singer and whilst I am quite happy to have my voice and film in the rendered version I feel that it would be better if individual recordings remained private to others.

I can't see anywhere on the website that allows me to do this. I actually suspect it will put a lot of people off recording once this becomes more widely known. My wife has refused to record for this reason.

I propose we only show the "View" button next to a song part in the following circumstances:

• if the song part was recorded by you i.e the song part's userId matches in the logged in user's userId
• if the logged in user is a leader of the choir
• if the song part was made by a leader of the choir i.e. a choir leaders rendition of the tenor part

In all other circumstances, a regular choir member should not be able to listen to another individual's (non choir leader's) parts.

[seanmtracey]

Conditions 1 and 2 can be met fairly easily and are in #111.

Condition 3 would require an API lookup for each contributor to the songs membership status in the choir. That'll greatly reduce the speed at which the choir song pages would load.

The individual pieces can still be viewed in part in the "record" view, which I think should be satisfactory for most of our users.

[glynnbird]

nice! Closing for now, we can revisit if the data model allows (3) in the future.

[monxton]

People with the "leader" attribute may be administrative leaders only, and also prefer that their submissions are not public!