search

Choirless / Application-Server

The front-end of the Choirless platform.
MIT License
6 stars 3 forks source link

When saving song part, add aspectRatio #65

Closed glynnbird closed 4 years ago

glynnbird commented 4 years ago

The Choirless API has room for the aspect ratio of a recording, so when the front end is calling POST /choir/songpart it should provide the aspectRatio attribute as a string e.g. 640:480

seanmtracey commented 4 years ago

Those are the dimensions, would it make more sense to have either the property as dimensions or the value as something like 16:9?

glynnbird commented 4 years ago

You're welcome to find the lowest common denominator and store that, but really this is to give to Stitcheroo/boxjam to calculate how to pack the boxes into a known space.

so 640:480 gives you both the dimensions and the ratio of X:Y, although not necessarily expreseed in its smallest form

On Mon, 13 Jul 2020 at 12:30, Sean M. Tracey notifications@github.com wrote:

Those are the dimensions, would it make more sense to have either the property as dimensions or the value as something like 16:9?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Choirless/Application-Server/issues/65#issuecomment-657504368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFKMRI2Z6K26LFHX7AUD5TR3LV5ZANCNFSM4OX546WA .

glynnbird commented 4 years ago

^ we could do with this data making it from the front end to the back end before embarking on the rendererv2 journey. @seanmtracey