ChongQiRong / pe

0 stars 0 forks source link

Unclear where the reference for parserLogic is for SEPHelper diagram #12

Open ChongQiRong opened 1 year ago

ChongQiRong commented 1 year ago

For the SEPHelper sequence diagram, there are two ref frames used.

image.png

image.png

The ref diagram for initialization follows right after image.png

but for the ref frame of parserLogic it is unclear where to locate it as it does not come right after initialization

nus-pe-bot commented 1 year ago

Team's Response

image.png

The reference block shows Parser logic, hence it will at the explanation of Parser as shown in the diagram above.

image.png

From the above picture, you are able to see the parseUserCommand call, which would indicate the Parser Logic to be in the Parser class that is further below where the explanation for Parser is.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: There should be a short explanation at least or even better a link to link straight to parser if not readers are left dangling