nus-se-script
commented
10 months ago Team's Response
As #243, #304 stated in the forum, handling invalid data in the JSON file is not a requirement and failing to do so shouldn't be considered as a bug, only running the app with correct data needs to be supported.
"If you modify the data file, you'd better know what you are doing". Here, changing "theme" to an invalid data input "test" is a case that user deliberately inputs invalid data to the JSON file. Thus, any consequence regarding this invalid data should not be in consideration.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: You are using a stance from the past, which states we do not want to qualify it as a bug "especially because we didn't mention such a requirement earlier."
This year, it is already explicitly mentioned as a requirement as shown in the screenshot below.
You should support a basic level of manual JSON file changes, at least to the extent AB3 did. AB3 handled it in a way that, if the values are invalid, it either tells you there's an error, or reset the JSON file in its entirety.
In this case, it was not handled. When the value is neither "default" or "dark", the app still opens as per normal in dark mode, but the stored value is automatically set to "default", which is white. This is obviously a functionality bug as it is not the intended behaviour. The value could have been automatically changed to "dark", in that case it would not be a bug.
After manually setting the preferred theme as test, the default theme goes to dark, even though the documentation states that the default is white. Classifying it as a functionality bug as I believe the intent was for default to be white.