Chooloo / koler

Just a phone app.
Other
933 stars 130 forks source link

Implement T9 dialing #214

Open anotherus3r opened 3 years ago

anotherus3r commented 3 years ago

Checklist

Describe the feature you want

T9 dialing would be a great feature. Most OEM dialer apps support it. T9 dialing allows you to search for a contact using the dialer number pad. E.g. entering 6453 would suggest a contact named Mike.

How will you/everyone benefit from this feature?

This would make it much faster to search for and call a contact. The lack of this feature is the only thing preventing me from switching to Koler from the default Huawei dialer app.

roeiedri commented 3 years ago

Can you elaborate on how this would work? because I don't know any dialers that implement this feature. Even Samsung's stock dialer doesn't have this.

anotherus3r commented 3 years ago

Hi @roeiedri. I found this old video that shows this feature. I think my old Samsung with Android 7 did have this feature. Not sure about newer Samsungs.

Edit: two other examples of dialer apps that support T9 dialing are Google's Phone app and Simple Dialer.

roeiedri commented 3 years ago

I don't fully understand the logic behind it, so how would you type the second letter under a number and not the first letter?

anotherus3r commented 3 years ago

You don't need to. The app searches for all the combinations. E.g. pressing 2 would search A, B and C. Or, per my first example, pressing 6453 would show contacts named "Mike" and "Nile" (or any other combination of the letters corresponding to the numbers in that order).

Gottarocket commented 3 years ago

You can check on open contacts its implemented by default I too felt its useless but lets us search quicker https://gitlab.com/sultanahamer/OpenContacts/

anotherus3r commented 3 years ago

You can check on open contacts its implemented by default I too felt its useless but lets us search quicker https://gitlab.com/sultanahamer/OpenContacts/

To add to this comment, Simple Dialer is also open source (source code is available here on GitHub), so you might be interested in checking out their implementation.

mizzunet commented 3 years ago

Can you elaborate on how this would work? because I don't know any dialers that implement this feature. Even Samsung's stock dialer doesn't have this.

It's like, search contacts by letter and number together, rather than just showing number result which is the current implementation

Contact Maria can be searched by 62742, in this case, when we type, 6, results are contacts start with number six, letters m, n and I At second digit, 2, result becomes, contacts starts with number six, letters m, n and I AND second number two, letter a, b, c At third digit, 7, result becomes, contacts starts with number six, letters m, n and I AND second number two, letter a, b, c AND third number seven, letter p, q, rs, t and likewise. Got it?

roeiedri commented 3 years ago

Ohh i got it It doesnt sound so bad to do :)

DodoLeDev commented 2 years ago

Hi! I just wanna bring up this topic again, because I really want this feature in a future release!

About the T9 dialing, I think I have an interesting idea to implement it...

Please note that I haven't checked any of the implementations mentioned above in this thread!

If searching in contacts based on the typed number isn't a optimal solution, why don't you act in a reverse way?

The solution I suggest is to generate a T9 number for each contact of the database

Then, just make the dialpad searching into those additional (hidden) fields!

Moreover, you could also split the search results to show T9 results on one side and phone number results on the other side!

What do you think, folks?

nanna7077 commented 1 year ago

Hi! I just found out about this app and I already ditched the Google Phone app but the only thing that's holding me back is the lack of T9 search. I hope it would be implemented and I'm already recommending this app to my friends.