search

Chooloo / koler

Just a phone app.
Other
933 stars 130 forks source link

add koler to the list of applications that can be used to call via open contacts #490

Open Wjxfi opened 1 year ago

Wjxfi commented 1 year ago

latest version

Describe the feature you want

add koler to the list of applications that can be used to call via open contacts

Additional context

simple dialer has already implemented this feature

How will you/everyone benefit from this feature?

without it, it makes no sense for me to use this app, since I only use OpenContacts. I'm sure other people think the same.

roeiedri commented 1 year ago

what do you mean "via open contacts"

Wjxfi commented 1 year ago

what do you mean "via open contacts"

https://www.f-droid.org/packages/opencontacts.open.com.opencontacts/

bserrao commented 1 year ago

Not sure if i fully understand your request. But it's already possible to use koler as the dialer app from the opencontacts app. You just need to set the koler app as default for dial and disable the always use system app dialer in opencontacts.

Wjxfi commented 1 year ago

There is no koler and that's why I can't choose it. 307885.jpg

bserrao commented 1 year ago

I belive that's an OS feature/limitation and not koler, because if you set koler as your default dialer app at the OS, koler will then be used for incoming and outgoing calls. I think you can set this going to koler app info and change the "Dial" option to "yes", but it might be different depending on the OS version and manufacturer customization. If your contats only reside on opencontacts you won't see the contact name when receiving a call, but that's an opencontacts feature, which info in only avaible within the app and isn't accessible by koler.

Wjxfi commented 1 year ago

I belive that's an OS feature/limitation and not koler, because if you set koler as your default dialer app at the OS, koler will then be used for incoming and outgoing calls. I think you can set this going to koler app info and change the "Dial" option to "yes", but it might be different depending on the OS version and manufacturer customization. If your contats only reside on opencontacts you won't see the contact name when receiving a call, but that's an opencontacts feature, which info in only avaible within the app and isn't accessible by koler.

The problem is in your app, as https://github.com/SimpleMobileTools/Simple-Dialer fixed this error. (I have miui)

ippocratis commented 1 year ago

The problem is in your app, as https://github.com/SimpleMobileTools/Simple-Dialer fixed this error. (I have miui)

Settings>apps>default apps>dialer>select koler>profit

anuraag488 commented 1 year ago

Well @Wjxfi is right. Issue is Koler doesn't handle ACTION_CALL intent. So when that intent is fired then Koler isn't shown. Setting Koler default app doesn't matter in this case.

roeiedri commented 1 year ago

@anuraag488 Its actually been fixed in a recent commit. Itll be in the next release.

ippocratis commented 1 year ago

Well @Wjxfi is right. Issue is Koler doesn't handle ACTION_CALL intent. So when that intent is fired then Koler isn't shown. Setting Koler default app doesn't matter in this case.

I have set koler as my default dialer in android settings and it is used as such

anuraag488 commented 1 year ago

Well @Wjxfi is right. Issue is Koler doesn't handle ACTION_CALL intent. So when that intent is fired then Koler isn't shown. Setting Koler default app doesn't matter in this case.

I have set koler as my default dialer in android settings and it is used as such

You may be using only one app which handles ACTION_CALL intent. In that case there will no option to choose. Anyway @roeiedri said it's fixed in next build.

ippocratis commented 1 year ago

https://user-images.githubusercontent.com/52239579/215263003-be9a21f8-90f9-460b-8f3a-ad1446587d64.mp4

Why the thumbs down?

Wjxfi commented 1 year ago

https://user-images.githubusercontent.com/52239579/215263003-be9a21f8-90f9-460b-8f3a-ad1446587d64.mp4

Why the thumbs down?

wow, what kind of operating system is this

It looks very beautiful

ippocratis commented 1 year ago

wow, what kind of operating system is this

The rom and launcher has nothing to do to what you want

Set koler as the default dialer in miui setting and open contacts will use it Instead of the stock dialer

The Rom is sparkOS A13 with Nova launcher

Wjxfi commented 1 year ago

Set koler as the default dialer in miui setting and open contacts will use it Instead of the stock dialer

did not help

The Rom is sparkOS A13 with Nova launcher

Thanks!