search

Chooloo / koler

Just a phone app.
Other
958 stars 134 forks source link

Added option to clear complete call log. Closes #61. #526

Closed alvi-khan closed 1 year ago

alvi-khan commented 1 year ago

The option to clear all recent calls is added to the 'Settings' menu. I know this isn't the most appropriate place for it but IMO it is the most intuitive.

My proposal for making this better: The fact that tapping on an item from the call log (with 'Group Similar Recents' turned on) brings up a full call log (with recents ungrouped) and not the option to call the number directly is unintuitive. The menu where 'Settings' currently is can be reworked to have three buttons: 'Clear Recents', 'View Complete Call Log' and 'Settings', the third of which opens a new page that shows the settings.

Also, I am aware that there is a bug where, after clearing recents, the 'Are You Sure' menu does not go away by itself. I did not fix this on purpose because the same bug already existed when clearing a single call log and I think the two should be fixed together in a separate issue.

roeiedri commented 1 year ago

Thank you very much! apologies for the long wait. Next time just please make the PR to the staging branch :)