ChoonSiang / pe

0 stars 0 forks source link

Inconsistency in the error message shown when user input invalid move for 'move' command #7

Open ChoonSiang opened 10 months ago

ChoonSiang commented 10 months ago

In the UG, it shows that the error message should be Oops, that move isn't valid. However, when a10 is input as the position to move to, the error message shows unable to parse coordinate. This is medium severity since the program targets beginner, who may not have knowledge about chess. And the different in error messages from the expected and the actual output may throw them off.

UG:

image.png

Test run:

image.png

nus-pe-script commented 9 months ago

Team's Response

We accept that the error message can be more specific.

However, this error is not due to an invalid move but rather an incorrect destination coordinate entered. Hence it is a duplicate of #358

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Too generic error messages when user is using the moves command

When the user is using the moves command. Regardless of invalid command argument (e.g. a, 1), out of board range argument (e.g. h9, j5), it all shows "unable" to parse coordinate. Perhaps, it will be better to indicate the usage of the command when invalid command argument is specified, and "out of board range" message to indicate that the user input a piece that is not in the valid board.

image.png


[original: nus-cs2113-AY2324S1/pe-interim#286] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]