ChordPro / chordpro

Reference implementation of the ChordPro standard for musical lead sheets.
Other
317 stars 51 forks source link

Add ChordPro to Windows system path #114

Open AnniePerson opened 4 years ago

AnniePerson commented 4 years ago

I installed ChordPro 0.975 on Win10 into the standard location c:\Program Files (x86)\ChordPro.ORG\ChordPro\chordpro.exe To be able to use the CLI of ChordPro.exe conveniently from other locations, I added c:\Program Files (x86)\ChordPro.ORG\ to the system path in the Win10 environment variables. That should be better done automatically by the installer. Or is there another way to do that?

sciurius commented 4 years ago

I agree this should be an installer function. However, much to my surprise, InnoSetup has no support for adding the application path to the system path decently, and, also important, remove it when uninstalled. There are some workarounds, each with pros and cons, that I would rather avoid.

I'll leave the issue as enhancement.

ghost commented 3 years ago

I too installed Chordpro into the standard location standard location c:\Program Files (x86)\ChordPro.ORG\ChordPro\

However, the shortcut to the gui has the path as c:\Program Files (x86)\ChordPro.ORG\ChordPro\bin\ so can't find the wxchordpro.exe executable. This path is in two places within the shortcut.

sciurius commented 3 years ago

I just verified that the installer installs the shortcut as C:\Program Files (x86)\ChordPro.ORG\ChordPro\wxchordpro.exe .

VirtualBox_Win10Pro_26_02_2021_19_38_52

ghost commented 3 years ago

Great. But my new installation put in the path I gave earlier. Today I downloaded the installer using the link here https://www.chordpro.org/chordpro/install-windows-native/ which downloaded ChordPro-installer-0-977-0-2-msw-x64.exe. On the face of it, I should have had the same result as you.

Are you using an updated installer? Did you update a previous version?

Although I'm a newbie to Chordpro, I'm quite experienced with computers which is how I managed to work out what was going on when Windows complained it couldn't find the target exe file. If you want screenshots, I'll uninstall and start again if you like.

sciurius commented 3 years ago

What installer did you use that gave the wrong results?

Have you tried uninstalling ChordPro, then install fresh using the installer from GitHub?

ghost commented 3 years ago

The page I downloaded it from is here: https://github.com/ChordPro/chordpro/releases/tag/R0_977 This is linked to by the page I mentioned in the last post.

and, yes, I installed it yesterday, had the problem and uninstalled without investigating too much. Decided today to try again and was more persistent in diagnosing what had gone wrong.

Have just uninstalled and reinstalled again. Attached are screenshots.

One thing that occurs to me: I don't like a cluttered Desktop. A hangover from years of IT support before I moved to a more technical job.

The only shortcut that I have is the one in the Start menu. It may be that the shortcut from the Desktop is different.

Screenshot 2021-02-26 22 02 55 Screenshot 2021-02-26 22 03 34

Sorry to be a pain!

sciurius commented 3 years ago

This is very surprising. The desktop shortcut is installed okay, but the entry in the start menu is wrong.

I opened a issue: https://github.com/ChordPro/chordpro/issues/135

ghost commented 3 years ago

Thanks.

I should have said which shortcut was incorrect in the first place but, presumably like yourself, I didn't think there would be a difference between the startup and the desktop shortcut.

sciurius commented 3 years ago

Please try ChordPro-installer-0-977-0-3-msw-x64.exe .

ghost commented 3 years ago

That version works fine.

nomike commented 3 years ago

BTW: Rather than adding the ChordPro installation directory to the path, it might be worth to look at this registry feature: https://docs.microsoft.com/en-us/windows/win32/shell/app-registration

This is what allows you to put "winword" in Start --> Run to run Microsoft Word.

sciurius commented 3 years ago

This should be handled by the installer program. AFAIK InnoSetup can not do this (at least I haven't found a way).