search

ChordPro / chordpro

Reference implementation of the ChordPro standard for musical lead sheets.
Other
306 stars 51 forks source link

Transcoding doesn't work properly for first file in list #201

Closed AdaSur closed 2 years ago

AdaSur commented 2 years ago

Describe the bug

When use file list, transcoding to german doesn't work properly for first file, if it contains Bb chord (chord diagrams are O.K. see output.pdf) If you use only that file, it works O.K. - see output_singlefile.pdf

Filelist.txt content: test.chopro test.chopro test.chopro test.chopro

out: output.pdf

To Reproduce

Steps to reproduce the behavior:

  1. chordpro.exe --config=default.json --filelist filelist.txt -o output.pdf
  2. chordpro.exe --config=default.json test.chopro -o output_singlefile.pdf

Expected behavior

Attachments

Test.chopro content: {title: Test song}

Thi[C#]s is a s[Bm]ample v[Bb]ers[Bbm]e

System information

Additional context

output_singlefile.pdf output.pdf

sciurius commented 2 years ago

A lot has changed in the area or transcoding, and it seems to work fine with the current git version:

chordpro -X --transcode german --config modern3 --filelist list.txt --output output.pdf

output.pdf

AdaSur commented 2 years ago

But there is no Hm chord diagram in your output.pdf.

From: Johan Vromans @.> Sent: Friday, January 14, 2022 7:17 PM To: ChordPro/chordpro @.> Cc: AdaSur @.>; Author @.> Subject: Re: [ChordPro/chordpro] Transcoding doesn't work properly for first file in list (Issue #201)

A lot has changed in the area or transcoding, and it seems to work fine with the current git version:

chordpro -X --transcode german --config modern3 --filelist list.txt --output output.pdf

output.pdf https://github.com/ChordPro/chordpro/files/7872393/output.pdf

— Reply to this email directly, view it on GitHub https://github.com/ChordPro/chordpro/issues/201#issuecomment-1013350068 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AXJYVIOHZP5QDWB77CR4UGDUWBSCLANCNFSM5L7HPCYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AXJYVILMWXEUH6E3GVKEO6TUWBSCLA5CNFSM5L7HPCY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHRTH5NA.gif Message ID: @. @.> >

AdaSur commented 2 years ago

And B and Bm chords diagrams are wrong, not in german notation (should be displayed Bb and Bbm)

From: Johan Vromans @.> Sent: Friday, January 14, 2022 7:17 PM To: ChordPro/chordpro @.> Cc: AdaSur @.>; Author @.> Subject: Re: [ChordPro/chordpro] Transcoding doesn't work properly for first file in list (Issue #201)

A lot has changed in the area or transcoding, and it seems to work fine with the current git version:

chordpro -X --transcode german --config modern3 --filelist list.txt --output output.pdf

output.pdf https://github.com/ChordPro/chordpro/files/7872393/output.pdf

— Reply to this email directly, view it on GitHub https://github.com/ChordPro/chordpro/issues/201#issuecomment-1013350068 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AXJYVIOHZP5QDWB77CR4UGDUWBSCLANCNFSM5L7HPCYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AXJYVILMWXEUH6E3GVKEO6TUWBSCLA5CNFSM5L7HPCY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHRTH5NA.gif Message ID: @. @.> >

sciurius commented 2 years ago

I'm afraid I can't follow you.

As far as I know, the common 'B' is 'H' in german, and common 'Bb' (B-flat) is 'B'. Also, sharp chords get a 'is' suffix and flat chords get a 'es' suffix. So the chords C# Bm Bb Bbm become Cis Hm B Bm in german. And that is what I see in the output.

scrot20220115104248

AdaSur commented 2 years ago

I run

chordpro -X --transcode german --config modern3 --filelist filelist.txt --output d:\output.pdf --debug

on fresh installation (downloaded from github) and this is debug and output.

This is ChordPro core 5.985

filelist.txt is ASCII (detected)

Reading:

RSC3: config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Config[0]:

Config[1]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Config[2]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Process:

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Chords: Created parser for common

Processed 418 chord entries

Totals: 573 config chords

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Parsers:

Parsers at start of test.chopro:

Processing song...

Chords: Created parser for common

Processed song...

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/notes/german.json

Chords: Created parser for german

Got transcoder for german

Parser: german

Parser: common

Parsers at start of test.chopro: *common german

Processing song...

Processed song...

Got transcoder for german

Parser: german

Parser: common

Cannot transcode Hm

RSC3: fonts/

Reading:

RSC3: config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Config[0]:

Config[1]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Config[2]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Process:

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Chords: Created parser for common

Processed 418 chord entries

Totals: 573 config chords

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Chords: Created parser for common

PDF: Unknown chord Hm in song starting at line 1 in test.chopro

RSC3: fonts/

Reading:

RSC3: config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Config[0]:

Config[1]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Config[2]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Process:

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Chords: Created parser for common

Processed 418 chord entries

Totals: 573 config chords

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Chords: Created parser for common

PDF: Unknown chord Hm in song starting at line 1 in test.chopro

PDF: Lookup chord B... found

PDF: Lookup chord Bm... found

RSC3: fonts/

Use of uninitialized value $file in -f at C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/Output/PDF/Writer.pm line 593.

RSC3: fonts/

Use of uninitialized value $file in -f at C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/Output/PDF/Writer.pm line 593.

chordpro -X --transcode german --config modern3 test.chopro --output d:\output_single.pdf --debug

This is ChordPro core 5.985

Reading:

RSC3: config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Config[0]:

Config[1]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Config[2]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Process:

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Chords: Created parser for common

Processed 418 chord entries

Totals: 573 config chords

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Parsers:

Parsers at start of test.chopro:

Processing song...

Chords: Created parser for common

Processed song...

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/notes/german.json

Chords: Created parser for german

Got transcoder for german

Parser: german

Parser: common

RSC3: fonts/

Reading:

RSC3: config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Reading: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Config[0]:

Config[1]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Config[2]: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Process:

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/guitar.json

Chords: Created parser for common

Processed 418 chord entries

Totals: 573 config chords

Process: C:/Program Files (x86)/ChordPro.ORG/ChordPro/script/../lib/App/Music/ChordPro/res/config/modern3.json

Chords: Created parser for common

PDF: Unknown chord Hm in song starting at line 1 in test.chopro

What can be wrong?

From: Johan Vromans @.> Sent: Saturday, January 15, 2022 10:44 AM To: ChordPro/chordpro @.> Cc: AdaSur @.>; Author @.> Subject: Re: [ChordPro/chordpro] Transcoding doesn't work properly for first file in list (Issue #201)

I'm afraid I can't follow you.

As far as I know, the common 'B' is 'H' in german, and common 'Bb' (B-flat) is 'B'. Also, sharp chords get a 'is' suffix and flat chords get a 'es' suffix. So the chords C# Bm Bb Bbm become Cis Hm B Bm in german. And that is what I see in the output.

https://user-images.githubusercontent.com/1118804/149617335-addb7baf-92e2-453c-ab63-7286f9909250.png

— Reply to this email directly, https://github.com/ChordPro/chordpro/issues/201#issuecomment-1013652459 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AXJYVIOJY5OBL7F7RYOGGGTUWE6VPANCNFSM5L7HPCYQ unsubscribe. Triage notifications on the go with GitHub Mobile for https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 iOS or https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub Android. You are receiving this because you authored the thread.Message ID: @.***>

sciurius commented 2 years ago

I said that this seems to have been solved in the development version (5.985_xxx). You are still running the stable version (5.985). See https://www.chordpro.org/chordpro/chordpro-run-from-git/

AnniePerson commented 2 years ago

With ChordPro-Installer-5-985-58-1-msw-x64.exe from https://groups.io/g/ChordPro/message/1136 I get the same result as in Sciurius' screenshot from yesterday. It shows the intended behaviour. ChordPro-Installer-5-985-31-2-msw-x64.exe still had issues.

AnniePerson commented 2 years ago

@AdaSur: what do you mean with "And B and Bm chords diagrams are wrong, not in german notation (should be displayed Bb and Bbm)" ? If you expect C# Hm Bb Bbm you should use "transcode scandinavian" instead of "transcode german"

sciurius commented 2 years ago

Closed due to lack of response.