ChordPro / chordpro

Reference implementation of the ChordPro standard for musical lead sheets.
Other
310 stars 51 forks source link

Unknown directives `sog` and `eog` #402

Closed devnibo closed 2 months ago

devnibo commented 2 months ago

Describe the bug

The short versions of the directives start_of_grid and end_of_grid, namely sog and eog aren't recognized.

To Reproduce

Run the following command against the test file I provided in the attachments section:

[~] chordpro --debug test.cho.txt
This is ChordPro core 6.050.7 
ChordPro invoked: --debug test.cho.txt
Writing output to test.cho.pdf
Reading: <builtin>
Reading: /usr/share/perl5/site_perl/ChordPro/res/config/guitar.json
Verify config "/usr/share/perl5/site_perl/ChordPro/res/config/guitar.json"
Config[0]: <builtin>
Config[1]: /usr/share/perl5/site_perl/ChordPro/res/config/guitar.json
Process: <builtin>
Process: /usr/share/perl5/site_perl/ChordPro/res/config/guitar.json
Chords: Created parser for common
Chords: Created parser for common
Processed 418 chord entries
Totals: 672 config chords
Parsers:
  common (active)
Processing song test.cho.txt...
Parsers at start of test.cho.txt: *common
"test.cho.txt", line 4, Unknown directive: sog: Intro
    {sog: Intro}
"test.cho.txt", line 6, Unknown directive: eog
    {eog}
Processed song...
Generating PDF test.cho.pdf...
Reading: <builtin>
Reading: /usr/share/perl5/site_perl/ChordPro/res/config/guitar.json
Verify config "/usr/share/perl5/site_perl/ChordPro/res/config/guitar.json"
Config[0]: <builtin>
Config[1]: /usr/share/perl5/site_perl/ChordPro/res/config/guitar.json
Process: <builtin>
Process: /usr/share/perl5/site_perl/ChordPro/res/config/guitar.json
Chords: Created parser for common
Processed 418 chord entries
Totals: 672 config chords
Generated PDF...

Expected behavior

Because the short versions are mentioned at https://chordpro.org/chordpro/chordpro-directives/ in the environment directives section I thought they would be recognized and treated as there long counterparts start_of_grid and end_of_grid.

Attachments

test.cho.txt

System information

sciurius commented 2 months ago

Good catch. Fixed in 6.050_101.