search

ChordPro / chordpro

Reference implementation of the ChordPro standard for musical lead sheets.
Other
322 stars 51 forks source link

Remove ChordPro from presets #413

Closed sciurius closed 1 month ago

Desbeers commented 2 months ago

Now the ‘chordpro’ preset is hidden from the GUI, hardcoded. It would be nice if it is moved out of config. Like in a new defaults for example? Then (in Config.pm):

    my $config = CP->findres( "chordpro.json", class => "config" );

would be:

    my $config = CP->findres( "chordpro.json", class => "defaults" );

Looks like a nice solution but I did not really looked into the code and it might break custom configs in ~/.config?

sciurius commented 2 months ago

Yes, that may be something that is worth to consider. However for the time being I would like to keep it as it is now. The config stuff is already far too complex and it may need a more thorough overhaul.

Desbeers commented 2 months ago

Related (more or less):

If I build from source; I do get more presets in the GUI than the official distribution has.

Like musejazz.json for example (that does not work out-of-the-box and the reason I found-out).

I understand why, they are not in a MANIFEST but that is something I don’t use.

What will be the best way forward to make sure they are in sync somehow? I suggest to remove them from the source.

Extra presets I have:

sciurius commented 2 months ago

Good point. 6.060_004 adds dark and removes the other files.