search

ChordPro / chordpro

Reference implementation of the ChordPro standard for musical lead sheets.
Other
325 stars 51 forks source link

Fix typos #419

Closed bobidle closed 2 months ago

bobidle commented 2 months ago

Hi i am new to ChordPro,

How is the best way to contribute to your Git repository? When pull requests should go to the dev branch and when to the master branch?

This pull request only contains some typo fixes for the Read Me First.html of ChordProMac.

What kind of style guilds should be followed e.g. commit messages, docs, perl code, ...

Thx and best regards Bob

sciurius commented 2 months ago

Thanks for your contribution! PRs should always be based on the dev branch. @Desbeers

Desbeers commented 2 months ago

Oh, thats embarrassing! I'm going to hide in a deep dark corner for a moment...

(but I'm happy he is a ChordProMac user!)

bobidle commented 2 months ago

Okay then i will re-create the pull request from and to the dev branch.

In the file on line 12 it is written This is not unfair, ... but i am unsure if the intention might be This is not fair, ...or This is unfair, ....

https://github.com/ChordPro/chordpro/blob/master/pp/macosswift/ChordProMac/Read%20Me%20First.html#L12

Desbeers commented 2 months ago

English is not my first language but what I mend with ‘not unfair’ is that I do understand the reasoning. So, it is ‘fair’ with a bit of hesitation :-)

I’m Dutch (and wrote the ChordProMac part).

bobidle commented 2 months ago

English is also not my first language. Thanks for writing the file, and also to clarify unfair vs. fair. I hope my changes are not seen as something to blame others.

And i am sorry but i am not a ChordProMac user. I just ran into that file somehow ;)

I opened a different pull request #420