Chordian / sidfactory2

SID Factory II is a cross-platform editor for composing music that will work on a Commodore 64. It uses the reSID emulator and is currently in open BETA.
http://blog.chordian.net/sf2/
110 stars 13 forks source link

183 fullscreen support #184

Open micheldebree opened 5 months ago

micheldebree commented 5 months ago

Draft for fixing #183

Hardcoded fullscreen

An extra clearing of the screen is done in viewport:End() to eliminate noise in the 'letterboxed' areas. This seems like a hack; I would like to understand why crap is rendered there in the first place.

TODO:

micheldebree commented 5 months ago

This isn't really a hack, since you're clearing the screen buffer before presenting the render buffer. I wonder if it needs to be done every frame though.

The noise looked like it changed on every frame (very quickly anyway). You can have a look if you take out the clearing step.

micheldebree commented 5 months ago

Mouse is not working properly at all in fullscreen :)

micheldebree commented 5 months ago

Mouse is not working properly at all in fullscreen :)

Fixed, but solution needs an SDL2 upgrade