e2e tests + update in withdrawal credentials

[jenpaff]

Task List:

• [x] remove 0x01 requirement for withdrawal addresses
• [x] e2e tests for existing-mnemonic command
• [x] e2e tests for new-mnemonic command
• [x] create export function that returns a struct
• [x] add error cases to e2e tests

More Context:

Withdrawal addresses:

To make it easier for users, we allow execution addresses with the format ^(0x[a-fA-F0-9]{40})$ e.g 0x0000000000000000000000000000000000000001, execution credentials ^(0x01[0]{22}[a-fA-F0-9]{40})$ e.g 0x0100000000000000000000000000000000000000000000000000000000000001or bls credentials with the format ^(0x00[a-fA-F0-9]{62})$ e.g. 0x00430635902478e3e943fadfc28214bd5eb8958f475391917ee5c62a1d905f99 . Ethereum wants to move away from 0x00 addresses and have users use the first ones. From what I've heard so far that means no changes are required on our side, just that 0x00 will not be used at some point.

Resources:

• Devcon panel: https://www.youtube.com/watch?v=zf7HJT_DMFw
• https://ethresear.ch/t/simple-eth1-withdrawals-beacon-chain-centric/8256
• https://github.com/ethereum/consensus-specs/blob/dev/specs/capella/beacon-chain.md#blstoexecutionchange

E2e test cases existing-mnemonic: Running the same inputs on staking-deposit-cli and comparing outputs

• [x] compare outputs with 1 validator + bls credentials overwrite
• [x] compare outputs with 1 validator + execution credentials
• [x] compare outputs with 1 validator + execution address
• [x] compare outputs with 1 validator , assert withdrawal credentials generated
• [x] compare multiple validators

E2e cases new-mnemonic: For obvious reasons, it's not possible to compare the outputs with the staking-deposit-cli in this case, therefore my idea would be to run the command and then run validations on the output (similar to as its done in staking-deposit-cli https://github.com/ethereum/staking-deposit-cli/blob/76ed78224fdfe3daca788d12442b3d1a37978296/staking_deposit/utils/validation.py#L43)

• [x] create 1 validator: Check if all key material is there with correct format + bls credentials
• [x] create 1 validator with bls credentials : Check if all key material is there with correct format + credentials\
• [x] create 1 validator with execution credentials : Check if all key material is there with correct format + credentials
• [x] create 1 validator with exeuction address: Check if all key material is there with correct format
• [x] create multiple validators: check everything ok

Refactoring This branch is still WIP, might do another iteration of refacotring

[jenpaff]

as for refactoring I was looking at the validators.rs maybe that could be split into validators.rs and export.rs cos it's getting quite big

[jenpaff]

as for refactoring I was looking at the validators.rs maybe that could be split into validators.rs and export.rs cos it's getting quite big

i might move this to another pr though- i also had another thing I wanted to add

[mksh]

as for refactoring I was looking at the validators.rs maybe that could be split into validators.rs and export.rs cos it's getting quite big

At a glance most of lines are tests, so could make sense to move tests out of the module and it will be 200 LoC

[jenpaff]

as for refactoring I was looking at the validators.rs maybe that could be split into validators.rs and export.rs cos it's getting quite big

At a glance most of lines are tests, so could make sense to move tests out of the module and it will be 200 LoC

hm not sure, quite like having the unit tests in the same module, because it's easy to track. Might skip this for now and merge. there's most likely going to be another opportunity to refactor before closing this task