search

ChorusOne / solido

Lido for Solana is a Lido-DAO governed liquid staking protocol for the Solana blockchain.
https://chorusone.github.io/solido/
GNU General Public License v3.0
101 stars 43 forks source link

Borsh dependency is out of date #294

Closed malikankit closed 3 years ago

ruuda commented 3 years ago

In v0.1.0 we use Borsh 0.8.2, the latest version at the time of writing is 0.9.0. None of the changes are relevant to us.

We can still update just for the superficial value of higher numbers. If we want to update it, we also need to update to a newer version of Solana, because we need solana-program’s implementation of BorshDeserialize for Pubkey. Solana v1.6.16 does use Borsh 0.9.0, so we should be able to update.

malikankit commented 3 years ago

Cool. Let's do it, if it's not time-consuming.

ruuda commented 3 years ago

Complication: The Multisig program uses an older version of anchor-lang which depends on Borsh 0.8.0. There is a new version, but it has breaking changes, so we would need to update the Serum multisig program first.

ruuda commented 3 years ago

Fixed by #359.