search

ChorusOne / solido

Lido for Solana is a Lido-DAO governed liquid staking protocol for the Solana blockchain.
https://chorusone.github.io/solido/
GNU General Public License v3.0
101 stars 43 forks source link

Stop calling `Anker::SendRewards` in maintainer #572

Closed ruuda closed 2 years ago

ruuda commented 2 years ago

The maintenance daemons are still trying to call Anker::SendRewards, and generating an error most of their duty time. It’s not really harmful, but it would be nice if they didn’t error so we can see when there is actually a problem.

We can make this a small 1.3.3 release just for the maintainer daemon, independent of the v2 stuff that @kkonevets is working on. Nobody is required to update, but I would like to update ours.

kkonevets commented 2 years ago

O, I have just noticed you requested my review. Need some time to finish current task and then I will check it, thanx

ruuda commented 2 years ago

Tagged this change as v1.3.3, which is on top of v1.3.2 directly, and not reachable from main. For merging to main, there is a conflict in CHANGELOG.md, I will resolve it and then merge it, just beware that the resulting commits will be different from the one that is tagged.

Actually I could just merge it, v1.3.3 is now reachable from main.