ChosenArchitect / Project-Architect-2

For issue regarding the Project Architect 2 Modpack
10 stars 1 forks source link

Stuck when Saving World #249

Closed Snowyfreezer closed 1 month ago

Snowyfreezer commented 1 month ago

Describe the bug A clear and concise description of what the bug is. -> Whenever the world is started it works normally. When logging out of the world it seems to be stuck on the saving world screen.

To Reproduce Steps to reproduce the behavior:

  1. Start the world
  2. Exit the world

Expected behavior A clear and concise description of what you expected to happen. -> The game should go back to the title screen after saving is finished.

Screenshots If applicable, add screenshots to help explain your problem. (Use F2 to take a screenshot in-game) image

Modpack version -> 4.4 Java Version -> 17.0.12.7 Modpack Launcher Used -> Prism Launcher Ram Allocated -> 12288 mb

Additional context Add any other context about the problem here. -> Log file 2024-09-26-12.log.gz https://pastebin.com/rvScGfAp

IRicTheCoder commented 1 month ago

Did you add any mods to the pack? If not break all your mekanism pipes that are of the type "Mechanical" that what is causing the error in the log. Try saving the world after that.

Snowyfreezer commented 1 month ago

It still seems to get stuck even after breaking this pipe 2024-09-27_13 04 50

2024-09-27-2.log.gz

Snowyfreezer commented 1 month ago

latest.log

Looks like something is wrong with a chunk?

[28Sep2024 15:56:17.371] [Server thread/INFO] [net.minecraft.server.network.ServerGamePacketListenerImpl/]: Stopping singleplayer server as player logged out
[28Sep2024 15:56:17.396] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Stopping server
[28Sep2024 15:56:17.396] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving players
[28Sep2024 15:56:17.396] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving worlds
[28Sep2024 16:01:24.433] [IO-Worker-17/ERROR] [net.minecraft.world.level.chunk.storage.IOWorker/]: Failed to store chunk [87, 7]
java.util.ConcurrentModificationException: null
    at java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) ~[?:?]
    at java.util.HashMap$KeyIterator.next(HashMap.java:1620) ~[?:?]
    at net.minecraft.nbt.CompoundTag.m_6434_(CompoundTag.java:133) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.nbt.NbtIo.m_128950_(NbtIo.java:139) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.nbt.NbtIo.m_128941_(NbtIo.java:108) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.world.level.chunk.storage.RegionFileStorage.m_63708_(RegionFileStorage.java:79) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.world.level.chunk.storage.IOWorker.m_63535_(IOWorker.java:260) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.world.level.chunk.storage.IOWorker.m_63553_(IOWorker.java:250) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.util.thread.StrictQueue$IntRunnable.run(StrictQueue.java:60) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.util.thread.ProcessorMailbox.m_18759_(ProcessorMailbox.java:91) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.util.thread.ProcessorMailbox.m_18747_(ProcessorMailbox.java:146) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at net.minecraft.util.thread.ProcessorMailbox.run(ProcessorMailbox.java:102) ~[client-1.20.1-20230612.114412-srg.jar%23792!/:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
    at java.lang.Thread.run(Thread.java:840) ~[?:?]
IRicTheCoder commented 1 month ago

Yeah that does seem related to the chunk itself, those are always hard to sort unfortunately, is the chunk being force loaded or claimed?

Snowyfreezer commented 1 month ago

I don't believe so, at least not anything in the overworld with those coordnates

Snowyfreezer commented 1 month ago

Well actually I'm not 100% sure on how to read and find the coordinates of that chunk

Snowyfreezer commented 1 month ago

oh I think I found the culprit 2024-09-28_17 01 33

World started saving normally when both are broken

IRicTheCoder commented 1 month ago

Guess we (you did) found it then, might be an issue with the Void Engines then, make sure it is working now, and get back to us

Snowyfreezer commented 1 month ago

2024-09-28_17 24 07 2024-09-28_17 24 54

Testing on a flat world, it seems like the Void motor's existence just causes it

Snowyfreezer commented 1 month ago

Works normally and returns to title properly!

2024-09-28_17 37 38 2024-09-28_17 37 49

IRicTheCoder commented 1 month ago

This is extremely helpful thank you, I will keep the issue open so we can look into it and see if there is a fix for it, or report it as an issue to the mod.

IRicTheCoder commented 1 month ago

Could not replicate this issue in testing, will add a tooltip to the motor saying it can cause TPS/Lag issues so people are warned it is a possibility. Will close the issue as solved since you did find the problem.