search

ChoukseyKhushbu / Gitzilla

A resume builder for your GitHub profile.
https://gitzilla.netlify.app/
MIT License
63 stars 10 forks source link

fixed some responsiveness issue #22

Closed Garvnanwani closed 3 years ago

Garvnanwani commented 3 years ago

In large screen sizes, the overflow-y can be hidden as the container is taking a min-100vh height but is leaving a blank white space at the bottom of screen when you scroll

ChoukseyKhushbu commented 3 years ago

Thank you @Garvnanwani for finding out this issue and really appreciate you for creating a PR too. I am looking into your changes. Will merge it soon after reviewing it from my side.

ChoukseyKhushbu commented 3 years ago

Hey @Garvnanwani, I have seen the preview of your PR. Your fix has created another issue. Have you checked the /user/<username>/ page after doing this fix? If not. then do check. You will see the problem.

If you can fix this problem, do tell me. Or else this PR is still open.

Thanks!

Garvnanwani commented 3 years ago

Sure, have a look now. The height property in sidebar was causing the issue

ChoukseyKhushbu commented 3 years ago

image

Actually, I think the sidebar should be fixed just as it was before. The scroll should only be applied to the main div containing repositories.

Removing the sidebar's height will make it attain the height of main div. This is happening because sidebar and main are children of container on which flex is applied. In flex, if you don't provide the children a specific height, all the children have the height of the children having largest height.

Garvnanwani commented 3 years ago

I tried to find out what was causing the little white space on the container and it was the image that was overflowing, so now check if the issue has solved or not

Garvnanwani commented 3 years ago

made the requested changes