Add website image to README.md

ChoukseyKhushbu / Gitzilla

A resume builder for your GitHub profile.

https://gitzilla.netlify.app/

MIT License

63 stars 10 forks source link

Add website image to README.md #44

Closed bloodzmoon closed 3 years ago

bloodzmoon commented 3 years ago

I've captured the website and added it in the README.md via relative path

PS. This is my very first time pull request to the open source 😅

netlify[bot] commented 3 years ago

Deploy request for gitzilla pending review.

Review with commit 327cd3582f56be6e2de461f06544f30f43ed5173

https://app.netlify.com/sites/gitzilla/deploys

ChoukseyKhushbu commented 3 years ago

Hey @bloodzmoon! Thank you for creating the PR. I am glad that Gitzilla helped you in your very first open source PR :tada: :smile:. Though I would like to have a few more enhancements -

Adding mobile view screenshot as well.
It will be great if you can add a screenshot template (for mobile and web both) :sweat_smile:
Can refer to this for that - https://www.labnol.org/internet/take-mobile-screenshots/28167/

bloodzmoon commented 3 years ago

Hey @bloodzmoon! Thank you for creating the PR. I am glad that Gitzilla helped you in your very first open source PR 🎉 😄. Though I would like to have a few more enhancements -

Adding mobile view screenshot as well.

It will be great if you can add a screenshot template (for mobile and web both) 😅 Can refer to this for that - https://www.labnol.org/internet/take-mobile-screenshots/28167/

Okay I'll do this! By the way thank you for the opportunity 😉

bloodzmoon commented 3 years ago

Is this image okay? I'm not sure haha if it's not I can change it.

ChoukseyKhushbu commented 3 years ago

Is this image okay? I'm not sure haha if it's not I can change it.

It looks good, but I guess, the background stuff is just taking too much attention, the mobile is not even visible that much. Having just the screens would also work. :sweat_smile:

bloodzmoon commented 3 years ago

Is this image okay? I'm not sure haha if it's not I can change it.

It looks good, but I guess, the background stuff is just taking too much attention, the mobile is not even visible that much. Having just the screens would also work. 😅

Okay I'll change it to cleaner template 😄

bloodzmoon commented 3 years ago

Is this image okay now? Sorry for my bad art sense 😓 I can change again and again If this image isn't okay

ChoukseyKhushbu commented 3 years ago

Is this image okay now? Sorry for my bad art sense I can change again and again If this image isn't okay

No need to be sorry @bloodzmoon! We all learn! Thank you for updating the requested changes! And welcome to open source :partying_face:!