search

Choumiko / Foreman

Other
12 stars 5 forks source link

Question on .admin change #18

Open Nexela opened 7 years ago

Nexela commented 7 years ago

importing from script doesn't require admin anymore (seemed to cause desyncs)

Was this tested? I looked over it and nothing it does should cause a desync.

Choumiko commented 7 years ago

Not tested. But it seemed plausible after coming back to Factorio modding after 4 months. I tried reproducing the desync without luck. 0.15 will have import/export for strings, so there's a good chance that Foreman will change into a blueprint manipulation tool only (the import from script could be turned into an admin only command i guess) If i remember correctly you just wanted it to be admin only because of possible exploits but there never was a problem? (like someone bringing down a server by executing an infinite loop in the script)

Nexela commented 7 years ago

The desync was from something else. your .admin check / print was done correctly I just forgot to comment that on the forum. (and if it was from foreman I would have made an issue 👍 ) Correct that it was a preventative thing :P .15 will still need script importing from foreman and I would love to have the .admin check back for it in that case.