Chowdhury-DSP / BYOD

Build-your-own guitar distortion!
GNU General Public License v3.0
433 stars 22 forks source link

[BUG] VST2 reverts on project reload in REAPER #133

Closed pauleye closed 2 years ago

pauleye commented 2 years ago

Describe the bug The VST2 version reverts to whatever preset is active when reloading a project. So for example if you start with the default (empty) preset, then add some modules and save your project, when reloading the project you'll be back at the empty default preset. Likewise if you pick a preset (user or built-in) and make some tweaks/additions to it, when reloading the project your setup will be reset to the chosen preset. The VST3 version doesn't do this.

Desktop (please complete the following information):

jatinchowdhury18 commented 2 years ago

Thanks for reporting this issue! Unfortunately, I have not been able to recreate the issue on my system. The only obvious difference is that I'm running a slightly newer version of Reaper (6.10). That makes me wonder if there may have been a bug in Reaper, which was later fixed.

Another thing that might be worthwhile would be to check the plugin log files, which can be found at C:\Users\<username>\AppData\Roaming\ChowdhuryDSP\BYOD\Logs. The logs should specifically show whenever the plugin is loading a preset, or adding/removing a processor or connection.

pauleye commented 2 years ago

I guess you mean to say you're running an older version of REAPER; 6.10 (which is almost 2 years old now) on your system versus 6.51 (the current/latest version) on my system. Here are 2 logs from when creating the project/plugin and loading. Notice how the 2nd log has entries for "removing processor". The image I uploaded shows how it's supposed to look like, but when loading the project it's empty. Link to the REAPER project: https://www.dropbox.com/s/8xdmoz4h0dq1vdh/BYOD-VST2-Test.rpp?dl=1 BYOD_Log_2022-03-14_07-10-43.log BYOD_Log_2022-03-14_07-14-37.log BYOD-VST2-Test .

pauleye commented 2 years ago

Here's 2 logs where I load the Jimi Hendrix preset, remove TS-Tone and Envelope Filter, then save the project, restart REAPER, and load the project. Something weird is going on when loading the project as the modules are created and removed several times. The end result is that the Jimi Hendrix preset is back at its normal state (TS-Tone and Envelope Filter not removed). BYOD_Log_2022-03-14_09-13-09.log BYOD_Log_2022-03-14_09-15-39.log

pauleye commented 2 years ago

And the Jimi test REAPER project: https://www.dropbox.com/s/zit6jg1agfdu3sq/BYOD-VST2-Test-Jimi.rpp?dl=1

jatinchowdhury18 commented 2 years ago

Ah, I feel silly! Of course version 6.10 is older than version 6.51. After updating to version 6.51, I was able to recreate the issue. The log files are very helpful as well, so thanks for those!

jatinchowdhury18 commented 2 years ago

This bug is now fixed with #137. The next nightly build will include the fix if you'd like to try it out!

pauleye commented 2 years ago

Yep, it works now, thanks for the quick fix :)