Chowdhury-DSP / BYOD

Build-your-own guitar distortion!
GNU General Public License v3.0
433 stars 22 forks source link

[BUG] Potential Build Issue #140

Closed GoodNoiseLLC closed 2 years ago

GoodNoiseLLC commented 2 years ago

Describe the bug I see a build issue with current master of BYOB and KlonCentaur source repo.

To Reproduce Steps to reproduce the behavior:

  1. cmake -Bbuild
  2. cmake --build build/ --config Release

Expected behavior I see the same issue with building BYOB repo. I can build the RTNeuralExample successfully and run in with Juce generated AudioPluginHost.

Screenshots Here is the [ 26%] Building CXX object ChowCentaur/CMakeFiles/ChowCentaur.dir/GainStageML/GainStageMLProc.cpp.o [ 26%] Building CXX object ChowCentaur/CMakeFiles/ChowCentaur.dir/GainStageML/RNNModel.cpp.o [ 27%] Building CXX object ChowCentaur/CMakeFiles/ChowCentaur.dir/__/modules/JUCE/modules/juce_audio_plugin_client/juce_audio_plugin_client_utils.cpp.o [ 28%] Building CXX object ChowCentaur/CMakeFiles/ChowCentaur.dir/__/modules/JUCE/modules/juce_audio_utils/juce_audio_utils.mm.o error: Objective-C was disabled in PCH file but is currently enabled 1 error generated. make[2]: [ChowCentaur/CMakeFiles/ChowCentaur.dir/__/modules/JUCE/modules/juce_audio_utils/juce_audio_utils.mm.o] Error 1 make[1]: [ChowCentaur/CMakeFiles/ChowCentaur.dir/all] Error 2 make: *** [all] Error 2

Desktop (please complete the following information):

KlonCentaurBuildError Image 3-14-22 at 6 43 PM

jatinchowdhury18 commented 2 years ago

Ah thanks for reporting this!

When I compile on Mac, I usually use Apple clang version 13.0.0 (clang-1300.0.29.30), I'd be curious to know if your compiler version is different (it should be available in the CMake logs)?

Another thing to try is to disable the pre-compiled headers, by commenting out this line.

GoodNoiseLLC commented 2 years ago

I was able to build BYOD with success today!

I pulled down the new v1.0.1 version today and used these commands to build:

If you'd like to make an optimized "release" build, it is suggested to use some slightly different build commands:

$ cmake -Bbuild -DCMAKE_BUILD_TYPE=Release $ cmake --build build --config Release --parallel 4

I am using the same compiler that I saw build issues prior to v1.0.1 release. Here is the output from CMake -Bbuild ... for today's build that worked: Merrils-iMac:BYOD merrilbradshaw$ cmake -Bbuild -DCMAKE_BUILD_TYPE=Release -- The C compiler identification is AppleClang 12.0.0.12000032 -- The CXX compiler identification is AppleClang 12.0.0.12000032 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Configuring juceaide -- Building juceaide -- Exporting juceaide -- VERSION for JUCE: 6.1.5 -- RTNeural -- Using xsimd backend -- Setting Clang compiler flags -- Configuring BYOD headless -- Found Git: /usr/bin/git (found version "2.24.3 (Apple Git-128)") -- Configuring done -- Generating done -- Build files have been written to: /Users/merrilbradshaw/Programming/BYOD/build Merrils-iMac:BYOD merrilbradshaw$ cmake --build build --config Release --parallel 4

GoodNoiseLLC commented 2 years ago

Closing this issue.

jatinchowdhury18 commented 2 years ago

Awesome, glad to hear the build process is working!