[BUG] - saving user presets doesn't save input / output gain, channel config, etc.

[mstgrv]

Describe the bug When saving user presets, the parameters along the bottom of the plugin window (channel config, input / output gain) are not saved with the preset.

To Reproduce Steps to reproduce the behavior:

1. Create a patch with non-zero input / output gain (e.g. stereo, output gain -6db)
2. Save as a user preset
3. Create a new instance of BYOD
4. Recall the user preset from step 2 - none of the parameters of input / output gain, channel configuration are recalled.

Expected behavior You expect that user presets will contain these parameters and they'll be recalled correctly. Not recalling input / output gain can cause unexpected loud bursts of audio when scrolling presets.

Desktop (please complete the following information):

• OS: macOS 12.3
• DAW: Ableton Live
• Version: 11.1

[jatinchowdhury18]

Thanks for reporting this issue! At the moment, I would consider this to be the "expected behaviour". It's actually mentioned in the user manual as well.

The original reason for this behaviour is that I was using the plugin in standalone mode, with my guitar plugged into channel 1 on my audio interface, with a few extra Decibels of input gain since input level was a litle bit low. I was annoyed at having to reset the channel configuration and input level every time I changed presets, so I decided to make the bottom bar parameters preset-agnostic. From previous plugins, I've also found that most users prefer the oversampling controls to be preset-agnostic as well.

That said, I definitely understand that scrolling the presets can lead to some volume jumps, so I tried to set up the factory presets to be roughly normalised to the same level, though I'm sure this could be imrpoved. Were there specific factory presets that you found to be drastically quieter or louder than others?