search

Chowdhury-DSP / BYOD

Build-your-own guitar distortion!
GNU General Public License v3.0
436 stars 23 forks source link

[BUG] Using Bitwig automation in the CLAP version distorts the shape of the automation #282

Open lewloiwc opened 1 year ago

lewloiwc commented 1 year ago

Describe the bug Using Bitwig automation in the CLAP version distorts the shape of the automation bwproject→https://drive.google.com/file/d/1-s3OBjzc-J2d2QgFBpMRyFJKn3Fyurpf/view?usp=sharing image

To Reproduce Steps to reproduce the behavior:

  1. Start Bitwig
  2. Place the DC signal on Track 1
  3. Load CLAP BYOD on Track 1
  4. Set Oversampling to 1x
  5. Add Clean Gain and set to -18 dB
  6. Write automation to Dry/Wet
  7. Add oscilloscope for waveform display to Track 1
  8. Playback.

Expected behavior I want it to have a smooth shape like the green dotted line. image

Desktop (please complete the following information):

Additional context This problem may possibly be related to this. https://github.com/free-audio/clap/issues/324

――――

[ PS: The REAPER issue has been fixed in reaper679+dev0518 ]

Also, this is about REAPER, but when I write such automation, is it normal behavior when the buffer size is large that the part immediately after playback is not displayed smoothly? https://github.com/free-audio/clap/blob/main/include/clap/ext/params.h ~~// Note: if the plugin is processing, then the process() call will already achieve the // parameter update (bi-directional), so a call to flush isn't required, also be aware // that the plugin may use the sample offset in process(), while this information would be // lost within flush().~~

This makes me feel like perhaps this is normal, but it seems a bit odd...

Light blue is CLAP: BYOD (chowdsp). (Red is CLAP: MFM2 (u-he), but it has nothing to do with this story.) https://github.com/Chowdhury-DSP/BYOD/assets/87447432/5fdad0a6-dc63-490e-aafb-8107fc3e4722

Translated with www.DeepL.com/Translator (free version)

jatinchowdhury18 commented 1 year ago

Thanks for the well-documented bug report! Just to confirm: this bug only happens in Bitwig (i.e. not in Reaper), and only with the CLAP build (i.e. not with the VST3 build)? If that's the case, I would guess that the issue is with the plugin/host interop, rather than something specific to BYOD. Either way, we'll make sure that it gets fixed :).

lewloiwc commented 1 year ago

You are correct, it currently only occurs when using CLAP with Bitwig. Until recently, REAPER also had an anomaly with CLAP automation, so we were not sure if the problem was caused by the host or the plugin, but now that we have confirmed that REAPER has been fixed and is working properly, we believe the cause is in Bitwig. Thank you for your response!

Translated with www.DeepL.com/Translator (free version)