Closed RachelMaryamLocke closed 1 year ago
Looking good overall! I was thinking it might make sense to override processAudioBypassed()
. In its current form, I think the bypass behaviour would just pass through the audio without going through the level detector. I think more likely the behaviour we would want would be a "silent" output if the processor bypassed. Would you agree?
Yes, I agree, it wouldn't make sense for the level output to send out mono audio information when the processor is bypassed, so in the case it is bypassed I have cleared the levelOutBuffer.
Let me know if I'm ok to merge this :)