Chowdhury-DSP / BYOD

Build-your-own guitar distortion!
GNU General Public License v3.0
427 stars 22 forks source link

Level Detective Processor - Audio Processing & Visualiser #322

Closed RachelMaryamLocke closed 1 year ago

RachelMaryamLocke commented 1 year ago
Screenshot 2023-07-25 at 00 51 08
jatinchowdhury18 commented 1 year ago

Looking good overall! I was thinking it might make sense to override processAudioBypassed(). In its current form, I think the bypass behaviour would just pass through the audio without going through the level detector. I think more likely the behaviour we would want would be a "silent" output if the processor bypassed. Would you agree?

RachelMaryamLocke commented 1 year ago

Yes, I agree, it wouldn't make sense for the level output to send out mono audio information when the processor is bypassed, so in the case it is bypassed I have cleared the levelOutBuffer.

RachelMaryamLocke commented 1 year ago

Let me know if I'm ok to merge this :)