Chowdhury-DSP / BYOD

Build-your-own guitar distortion!
GNU General Public License v3.0
427 stars 22 forks source link

[BUG] clap-juce-extension submodule unreachable #328

Closed hfiguiere closed 1 year ago

hfiguiere commented 1 year ago

Describe the bug THe clap-juce-extension submodule is unreachable because the commit is not on any branch.

To Reproduce Steps to reproduce the behavior:

  1. The flathub build. Logs https://buildbot.flathub.org/#/builders/19/builds/6969

Expected behavior

Git submodule update --recursive works

Screenshots

image

Desktop (please complete the following information):

Additional context

See #256

hfiguiere commented 1 year ago

Note that this doesn't happen when doing a regular git clone / update.

but the risk is that the commit disappear as it gets garbage collected.

jatinchowdhury18 commented 1 year ago

Thanks for the report! This should be fixed with b644c032cd5cdc2267598908d680b10b640bfc08 if you could confirm?

hfiguiere commented 1 year ago

Yes this solve the problem. Thank you !