search

ChriD / node-raumkernel

A nodeJs lib for controlling the raumfeld multiroom system
MIT License
17 stars 7 forks source link

Favourites are not in correct order if user has items and containers bookmarked #48

Closed ulilicht closed 3 years ago

ulilicht commented 3 years ago

Hello,

I found an issue with Favourites: If a user has bookmarked a mix of items and containers, the sorting of the favourites returned by raumkernel is not correct. This can e.g. happen if a user has bookmarked podcasts and radio stations.

The behaviour is related to this issue within xml2js: https://github.com/Leonidas-from-XIV/node-xml2js/issues/31

I tried to create a fix, but I don't have many test scenarios at hand so please merge with care only and please review before merging :)

What do you think about the approach - can there be any side effects? Are there other places in code where a similar issue could appear?

I don't have a large media library to test, so I don't know if there could be any performance side effects of the new configuration to xml2js. (Most likely not)

Best, Uli

ChriD commented 3 years ago

Thanks for the contribution! I will check this.

ulilicht commented 3 years ago

Sorry I had to close this PR as it was directly created from my master Branch. New PR with same changes can be found here: https://github.com/ChriD/node-raumkernel/pull/49