I found an issue with Favourites: If a user has bookmarked a mix of items and containers, the sorting of the favourites returned by raumkernel is not correct. This can e.g. happen if a user has bookmarked podcasts and radio stations.
The behaviour is related to this issue within xml2js: Leonidas-from-XIV/node-xml2js#31
I tried to create a fix, but I don't have many test scenarios at hand so please merge with care only and please review before merging :)
What do you think about the approach - can there be any side effects? Are there other places in code where a similar issue could appear?
I don't have a large media library to test, so I don't know if there could be any performance side effects of the new configuration to xml2js. (Most likely not)
This is a replacement PR of old PR https://github.com/ChriD/node-raumkernel/pull/48
Hello,
I found an issue with Favourites: If a user has bookmarked a mix of items and containers, the sorting of the favourites returned by raumkernel is not correct. This can e.g. happen if a user has bookmarked podcasts and radio stations.
The behaviour is related to this issue within xml2js: Leonidas-from-XIV/node-xml2js#31
I tried to create a fix, but I don't have many test scenarios at hand so please merge with care only and please review before merging :)
What do you think about the approach - can there be any side effects? Are there other places in code where a similar issue could appear?
I don't have a large media library to test, so I don't know if there could be any performance side effects of the new configuration to xml2js. (Most likely not)
Best, Uli