Make Key.h less likely to conflict with other libs

Chris--A / Keypad

A version of the keypad library found in Wiring. This is just a copy made compatible with the Arduino IDE library manager.

GNU General Public License v3.0

257 stars 156 forks source link

Make Key.h less likely to conflict with other libs #2

Closed PaulStoffregen closed 8 years ago

PaulStoffregen commented 8 years ago

Some other libs, particularly for USB keyboard support, define "KEY_H".

This very simple change avoids those conflicts by making Keypad's #define more unique.

Chris--A commented 8 years ago

Yeah, I'll push this through, and do a new release.

PaulStoffregen commented 8 years ago

Thanks!

I've had at least 2 people run into tough compile errors when using this with USB keyboard code. There's pretty much no way normal Arduino users could possibly figure out this sort of conflict, since the errors manifest in when compiling other files.

PaulStoffregen commented 8 years ago

Any chance to merge this soon? It issue came up again today on our forum.

https://forum.pjrc.com/threads/32875-HelloKeypad-Example-Does-Not-Compile

Odds are good more cases are occurring elsewhere too...

Chris--A commented 8 years ago

I've merged it, when I get home this afternoon (have booked in my phone), I'll update the library.properties and push a new tag.

I'll post back when done.

Chris--A commented 8 years ago

Updated and released new tag! (3.1.1)

Thanks for the PR

PaulStoffregen commented 8 years ago

Thanks! :)