Chris-Greaves / planka-helm-chart

A Helm Chart to deploy Planka and it's dependencies.
2 stars 1 forks source link

Remove coupled BASE_URL and Ingress host #3

Closed rocketproto closed 1 year ago

rocketproto commented 1 year ago

Sets an overall baseUrl value to remove the need for an ingress to set a custom host.

Tested with baseUrl set and unset and behaving as desired. I don't have then environment to triple-check if the ingress method still works but it should

Note:

Don't mind if I didn't do something quite right. First time contributing to open source and using Github. Work uses Gitlab :)

Let me know if you have any questions!

Chris-Greaves commented 1 year ago

Abandoning as this has now been raised on the official repo. I will create a new PR shortly to add details about this repo's deprecation.