Closed Chris-Johnston closed 6 years ago
So I was looking through PR #86 and I noticed that @AdamuKaapan has already implemented the CMP OPCODE in that PR. Is this the same implementation? If not, then how should we go about merging everyone's work?
I had forgotten about that branch, since it had been failing the build for a while. Also, since PR #104 changed a lot of the way that opcodes are written, it may just be easier to re-do some of that work.
Could we rebase PR #86 with PR #104 and refactor it?
To be honest, that sounds like more effort than it's worth. A lot of it would have to be rewritten anyways.
Then would it be best to close PR #86 for now?
To be honest, that sounds like more effort than it's worth. A lot of it would have to be rewritten anyways.
Is there anything else that should be done for this PR?
Looks good! Sorry for the delay in PR review.
Adds the CMP Opcode which is responsible for setting all of the CCR bits.
Fixes #25 .