search

Chris-Johnston / Easier68k

Work In Progress - A Python M68k assembler and simulator.
https://chris-johnston.me/Easier68k/
MIT License
15 stars 6 forks source link

Add CMP Opcode #109

Closed Chris-Johnston closed 6 years ago

Chris-Johnston commented 6 years ago

Adds the CMP Opcode which is responsible for setting all of the CCR bits.

Fixes #25 .

bpas247 commented 6 years ago

So I was looking through PR #86 and I noticed that @AdamuKaapan has already implemented the CMP OPCODE in that PR. Is this the same implementation? If not, then how should we go about merging everyone's work?

Chris-Johnston commented 6 years ago

I had forgotten about that branch, since it had been failing the build for a while. Also, since PR #104 changed a lot of the way that opcodes are written, it may just be easier to re-do some of that work.

bpas247 commented 6 years ago

Could we rebase PR #86 with PR #104 and refactor it?

Chris-Johnston commented 6 years ago

To be honest, that sounds like more effort than it's worth. A lot of it would have to be rewritten anyways.

bpas247 commented 6 years ago

Then would it be best to close PR #86 for now?

Chris-Johnston commented 6 years ago

To be honest, that sounds like more effort than it's worth. A lot of it would have to be rewritten anyways.

bpas247 commented 6 years ago

Is there anything else that should be done for this PR?

Chris-Johnston commented 6 years ago

Looks good! Sorry for the delay in PR review.