search

Chris-N-K / napari-time-series-plotter

A napari Plugin for visualisaton of pixel values over time (t+ nD) as graphs.
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Try to Fix compatibility with new napari mpl api #30

Closed rjlopez2 closed 9 months ago

rjlopez2 commented 11 months ago

This is mostly a demo to remake the plotting functionality using the latest napari-matplotlib widget and not intended to be a fix. Here I have renamed the variable self.layers, which I believe is creating conflicts from the self.layers object from the main viewer. The changes allow plotting in ROI mode only. No test has been doing in the other modes (points, voxel).

To reproduce the plotting, install the package in a clean environment, load an image (t, x, y) an draw some rois, then tick on the given image layer selector and the plot profiles of the ROIS should appear.

The canvas layout for some reasons is destroyed (need to be actually carefully checked with the new napari-matplotlib).

I hope this is a good start to investigate the actual issue(s) with this changes.

Appreciate feedback, hints and ideas where to go further...,

cheers

Chris-N-K commented 9 months ago

Hi @rjlopez2, took actually forever but I did take a look and reworked nearly the entire plugin. I will go in detail in issue #27 Thanks for your work and I would appreciate if you would be willing to test the reworked plugin. If you want to test it install from the layer_selection_rework branch.