Read nyx sims - Githubissues

Chris-Pedersen / LaCE_manager

Cosmological emulator for the 1D flux power spectrum of the Lyman-alpha forest

3 stars 1 forks source link

Read nyx sims #48

Closed andreufont closed 2 years ago

andreufont commented 2 years ago

Added a test file with a handful of Nyx simulated P1D, and the minimum code to read that and create a p1d archive.

Added also a couple of notebooks comparing archives and emulators.

andreufont commented 2 years ago

@Chris-Pedersen - this is harmless PR, in the sense that it does not impact the rest of the code (or ongoing projects), but I thought I'd let you review it since it is short and your feedback might be useful.

andreufont commented 2 years ago

@Chris-Pedersen - yes, this would be great, but we have two caveats:

we still only have a very small subset of Nyx measurements (4 sims!), so I don't think we could get anything proper yet
it would require some code development, like writing a mock Nyx object (like the dataMPGadget class). It should be doable, I'll open an Issue and come back to this soon.

I'll merge the PR now though