Consider removing pivot_scalar

Chris-Pedersen / LaCE_manager

Cosmological emulator for the 1D flux power spectrum of the Lyman-alpha forest

3 stars 1 forks source link

Consider removing pivot_scalar #53

Closed andreufont closed 2 years ago

andreufont commented 2 years ago

There are 40 lines that use pivot_scalar in the code, but I'm not sure why we need this. @Chris-Pedersen , where do you use it?

I noticed, for instance, that we had a bug in shift_primordial_pivot when using a different pivot_scalar for cosmologies with running. I added an assert to identify this problem, but I wonder whether we can get rid of this altogether.

Chris-Pedersen commented 2 years ago

Happy for this to go!

andreufont commented 2 years ago

Being addressed in #75