search

Chris-Pedersen / LaCE_manager

Cosmological emulator for the 1D flux power spectrum of the Lyman-alpha forest
3 stars 1 forks source link

Refactored name and imports #62

Closed Chris-Pedersen closed 2 years ago

Chris-Pedersen commented 2 years ago

Refactor code to lace_manager. Emulator code will be imported from https://github.com/igmhub/LaCE as a submodule, with duplicate code removed from lace_manager

Chris-Pedersen commented 2 years ago

Ah unfortunately this is looking to be less straightforward than I initially had hoped. We can add lace as a git submodule, but the tricky bit will be having one single setup.py that will install both lace and lace_manager. If we simply add lace as a submodule, the user will have to cd into the lace directory, run setup.py, then run the setup.py for lace_manager afterwards. It seems non-trivial to have one setup.py that installs both git repos. One suggestion on stack is to use pip to deal with the install. I might just do the simplest case (run with 2x setup.py) for now just to have the refactor complete, and we can come up with a more streamlined installation at a later point.

andreufont commented 2 years ago

@Chris-Pedersen - I'd do whatever works now, and we can always try something fancy in the future. Having to run twice setup.py doesn't seem too painful.