Chris-Pedersen / LaCE_manager

Cosmological emulator for the 1D flux power spectrum of the Lyman-alpha forest
3 stars 1 forks source link

Fixed background runs #75

Closed andreufont closed 2 years ago

andreufont commented 2 years ago

Two main changes:

Probably better to wait a bit to merge, since I might use this PR to clarify the differences between true cosmo and fiducial cosmo

andreufont commented 2 years ago

The discussion on true cosmo vs fiducial cosmo is related to #28 . Let's chat about this after the deadlines.

andreufont commented 2 years ago

Not directly related, but while cleaning up the code I decided to get rid of pivot_scalar (#53). None of the sims in Australia20 have specified pivot_scalars, and I don't see why we would want to change that when sampling. We should look at the pivot scale of our compressed parameters, but the pivot scale of the primordial power is not that interesting.

I've added sanity checks to catch any inconsistency with old chains or similar.

andreufont commented 2 years ago

approved over Zoom!