search

Chris-plus-alphanumericgibberish / dNAO

Merge of dnethack onto the nethack.alt.org sources.
Other
20 stars 29 forks source link

Shaktari statue in level creation has cobj point to zerobj if Sting of the Poison Queen has been generated #2251

Closed demogorgon22 closed 5 months ago

demogorgon22 commented 5 months ago

I think the title describes the cause but I may be wrong. Found in ndnh, should apply to dnh.

image This leads to trying to free zerobj when trying to save the level which is very bad and can crash. image This isn't safe and can lead to cobj being zerobj if the wish fails I guess? This handling should be fixed to not use zerobj and instead a ptr to no object.