Chris-plus-alphanumericgibberish / dNAO

Merge of dnethack onto the nethack.alt.org sources.
Other
22 stars 29 forks source link

Rename "shining" property (armor-phasing) to "phasing" under the hood, invent lookup fixes #2261

Closed RikerW closed 7 months ago

RikerW commented 7 months ago

Brought up by ScienceBall, it's a little inconsistent. In particular, it's only ever referred to as "armor-phasing" for the player, and "shining" means an entirely different object property (OPROP_SFLMW, the phasing one is "faded")

There's no real reason not to rename it, and thankfully it's relatively contained by calls to arti_shining that aren't really spammed because thanks xhity or something probably

Also fix invent lookup to properly show cross-aligned bonus damage for non-physical weapons (mirror brand etc.), have better messaging for misc properties, and include spe_mult as a line in the menu.