Chris-plus-alphanumericgibberish / dNAO

Merge of dnethack onto the nethack.alt.org sources.
Other
20 stars 29 forks source link

Invent lookup improvements #2262

Closed RikerW closed 3 months ago

RikerW commented 4 months ago

Add extra 'otyp-specific' damage to invent lookup

This is the damage/effects that are handled in artifact.c, like insight damage etc. Also includes some improvements to other otyp-specific damage, like making sure crystal swords & seismic hammers properly adjust their damage.

Also, changes the studied message to "vulnerable" instead of "weakened". Studied does not nerf your damage, that's morale, so it's now "vulnerable" to represent how it actually makes you take more damage. Maybe morale could be "weakened" instead, but that's not my problem right now. I do support that change though.

Add dbon + information about what causes it to invent lookup

Now, you can actually see both the stats your weapons scale with and your effective dbon. Strength IS dependent on the context of the weapon at the minute, for things like katanas etc.

Refactors the dbon function to use a new atr_dbon function that tells you the scaling, basically, and externs that for use in invent lookup. Also makes OPROP_ELFLW wizwishable for testing purposes.

Display a consistent message about sflame/goat/yog oprops, regardless…

… of their form

Mostly to indicate that this item actively sacrifices/offers/feeds that dude, so that it's more directly stated "this weapon is a cult item".

Some artifact effect messages, by no means comprehensive 96f8012

Just some that were easy to add. I probably won't continue this for now.

Also fixes bare-handed attacks + monster attacks not working with str bon, whoops.


No plans to add anything more to this PR - I mean, I thought that when I made it, but this is officially fin.