search

Chris-plus-alphanumericgibberish / dNAO

Merge of dnethack onto the nethack.alt.org sources.
Other
20 stars 29 forks source link

Applying the curseproof glaze to a helm via the silver flame is not shown #2266

Open NetSysFire opened 3 months ago

NetSysFire commented 3 months ago

Steps to reproduce:

  1. Acquire 250 FlameCredit and FlameDevotion so you can apply a major boon and a mithril/silver/platinum helm to apply it to.
  2. Apply a curseproof glaze.
  3. It finishes successfully, but the oprop is shown neither in the item name even when fully identified. Someone on IRC told me the oprop is still there and works I think, its just not displayed.

Related: Weapons show the same behavior but their curseproof glaze does not appear to do anything.

Expected behavior:

The item is shown as glazed.

For weapons: Do not allow them to be glazed unless the glaze actually has an effect.

RikerW commented 3 months ago

Fixed in dev - was changed to be only body armor, and should display appropriately if applied via any other means as well

NetSysFire commented 3 months ago

Which commit?

RikerW commented 3 months ago

behavior changed 2390fc0afaf7d161022f9b0addab607171c0615f, was bugged (couldn't be applied period) so fixed by noisy and merged via 86bcf06bb45e755bd987fbff45501fdb2ec90d4e