Chris-plus-alphanumericgibberish / dNAO

Merge of dnethack onto the nethack.alt.org sources.
Other
20 stars 29 forks source link

Minor misc bugfixes for various minor misc bugs #2267

Closed RikerW closed 3 months ago

RikerW commented 3 months ago

Squashed commit of a bunch of one-line changes that I'm not going to separate out, but they have sufficient descriptions it should be searchable.

Update singing sword regen to properly function when polymorphed: Also fixes the rather egregious copypastes present here. It now duplicates minimal code and messages slightly better.

Riders always leave corpses even on "nocorpse" levels: Please don't make anything not leave corpses unless corpse_chance says it's ok :(

Vault guards now see invisible and re-render correctly: This prevents them from being weird because they can still detect you, since they can still detect you via various means. See invisible doesn't make much of a difference in existing behavior but it explains it better

Spellbooks don't ID unless you actually begin reading them: This means cursed spellbooks that fail immediately no longer formally type ID themselves

Fix wornmask checks for sneak attacks for POTV & Lolth's Fang: As-written, most sneak attack enabling items require wielding/offhanding/etc. - this means they do NOT work when thrown, since that wornmask is cleared as soon as it hits the air and leaves your person. This fixes that behavior to be consistent for Lolth's Fang, but disables it for the PotV with Andromalius inside. It can sneak attack when thrown or whatever, since both it's an actual throwable object type & this makes it get sneak attacks when theoretically miska offhanded (since no wornmask htere).

Draw initial window boxes correctly in curses with certain options: !legacy and some other ways could make this not render the box around the prev msg window & some other ones, without this.

Scorpion Carapace plates upgrade now correctly gets +5/5 from plates upgrade, not set to 7/7: Reported by Zoe on github