Chris-plus-alphanumericgibberish / dNAO

Merge of dnethack onto the nethack.alt.org sources.
Other
20 stars 29 forks source link

Change polyform max hp to factor in player level more directly and ad… #2279

Closed RikerW closed 2 months ago

RikerW commented 2 months ago

…just drain mechanics

Polyself now takes into consideration both player level & form level when calculating hp. This has two major effects from the previous behavior:

In short - polyform max HP went up, drain4gain polyform max HP went wayyyy down.

Alternative solutions: detach player level & polyform level, so that gaining a player level does not affect your polyform hp. I considered this, but I decided on "~500 hp is cheap if you optimize, and there's no need to make low-level polymorph forms even more unusable than they currently are." I also considered trying to average the levels, or cap them at 45, but decided that was more trouble than it was worth.

Also, something's up with bonus HP & polyform max hp. I haven't touched that at ALL, but if when I drink !oFH until I stop getting HP as a lurking one human wiz with 25 con, I capped out at exactly 1778 hp. If you repoly, you'll cap out at 1221 or something. I don't know why, my guess is the "gain bonus hp" code vs. the 'recalc max hp on form shift' code disagree when polymorphed.

RikerW commented 2 months ago

2244