search

Chris1234567899 / flutter_time_range_picker

A time range picker for Flutter
MIT License
33 stars 53 forks source link

Feature/make time range picker public #3

Closed JanezStupar closed 4 years ago

JanezStupar commented 4 years ago

I made a couple of changes to the picker so it can be used as standalone widget, without using the dialog. Added a flag to not display a button bar. Changed visibility of builder functions so that picker can be extended and behavior overridden in client apps.

Chris1234567899 commented 4 years ago

I'm generally ok with this, just one thing I noticed:

in the last commit you added the widget in the example home page. However it does not scale well in landscape mode. I think it's just a minor thing because of the parent widget (Expanded + Column).

Once this is fixed I'll merge it.

JanezStupar commented 4 years ago

@Chris1234567899 there you. Let me know if this is satisfactory.

Chris1234567899 commented 4 years ago

Had to switch to a custom gesture detector to fix the conflict with scroll when in a scrollview. Should work now

JanezStupar commented 4 years ago

Thats perfect. Much better than what I attempted in the other PR.

Chris1234567899 commented 4 years ago

Thanks, I just published the changes under 1.1.0