search

Chris1234567899 / flutter_time_range_picker

A time range picker for Flutter
Other
33 stars 52 forks source link

Added headerBackground color as parameter and updated the using themeData.colorScheme.primary instead of themeData.primaryColor #37

Open Mayb3Nots opened 2 years ago

Mayb3Nots commented 2 years ago

I don't think replacing the activeColor and inactiveColor like this is favorable. I implemented it like this to help the user recognize which time (start or end) he is manipulating when moving the slider.

Well im doing this just to match the material spec's design. Using the ThemeData.colorScheme.primary and ThemeData.colorScheme.onPrimary will still have a contrast where users will still be able to see the selected time. Its just that now its according to the MaterialApp's theme which looks way better compared to the default colors.

Chris1234567899 commented 2 years ago

Can you post an example screenshot? I tried, but both texts (active and inactive) are just white - no difference. Which makes sense, because you got rid of the color difference between active and inactive.

I'm generally ok with making the header background color as parameter and using the colorScheme as default. Yet I think the visual difference between active and inactive time should persist. Maybe an opacity value could be used instead?

Mayb3Nots commented 2 years ago

Can you post an example screenshot? I tried, but both texts (active and inactive) are just white - no difference. Which makes sense, because you got rid of the color difference between active and inactive.

I'm generally ok with making the header background color as parameter and using the colorScheme as default. Yet I think the visual difference between active and inactive time should persist. Maybe an opacity value could be used instead?

I think its because you didnt configure your ThemeData's colorScheme?

My app's theme is red color and you can see how it looks like here image

Also its worth mentioning that the cruves for the header is not showing