search

Chris2011 / minifierbeans

Plugin to minify JS , CSS and HTML for quicken page load times by reducing the size of js/css/html files.
http://plugins.netbeans.org/plugin/49666/js-css-minify-compress
Apache License 2.0
37 stars 9 forks source link

[BUG] Minifier doesn't work with non-latin path #90

Closed Ilya-Zhulin closed 2 years ago

Ilya-Zhulin commented 3 years ago

Search first Please make sure, that your issue is not covered by any other ticket. Please search first before you create a ticket.

Describe the bug Error of minification if project path contains non latin simpbols - russian in my case (Документы).

To Reproduce Steps to reproduce the behavior:

  1. Go to on your PC
  2. Click on NetBeans icon
  3. Start new project
  4. Create new project in the path with non-latin folder name
  5. Create JavaScript file
  6. Fill it by some code
  7. Save this file
  8. Try to minify it.
  9. See error

Expected behavior I expect, that plug-in works with all path and file will be minified. It works with Latin path.

Screenshots image

Environment (please complete the following information):

Additional context Now I use Netbeans 12.5 and minifier 3.4. You can copy this word Документы to call your folder to replay the problem. This word means Documents.

Chris2011 commented 3 years ago

Hey @Ilya-Zhulin sry but I did create the issue template w/ good reason. So why didn't you follow the template? Next time I will close the ticket immediately. So as I need to GUESS, you minified one file, right?

Please next time, read the template, go step by step and add every little information that needs to identiy the bug. Thx.

Chris2011 commented 3 years ago

Also a title is missing.

Ilya-Zhulin commented 3 years ago

I described all needed info. I felt your template, now you have also info about my PC.

Chris2011 commented 3 years ago

Will have a look soon. Thx for reporting :)

Chris2011 commented 2 years ago

Unfortunately this bug is coming from the google closure compiler. Will check whether there is an update or an existing bug there. Or maybe there is a command line argument wrong from my side.

Chris2011 commented 2 years ago

@Ilya-Zhulin please see the last comment: https://github.com/google/closure-compiler/issues/3784#issuecomment-1011453062

Chris2011 commented 2 years ago

So my workaround on this and also I guess it is not really common to use non latin characters for filenames (Just IMHO). For development we should already use latin stuff, so I would ask you whether you can rename just your files to latin names. I think/hope that the code inside the file should work.

Ilya-Zhulin commented 2 years ago

Hey! Of course it is not common situation.. I just found it and report to dev. Thanks that you tried to solve it. It's not a big problem, I transferred my files time ago to latin path and now it works good. Thank you.

Chris2011 commented 2 years ago

Great you for your understanding :)