Design Docs Review #1 - Githubissues

Chris6135 / The-Academy

0 stars 0 forks source link

Design Docs Review #1 #1

Open jliversi opened 4 years ago

jliversi commented 4 years ago

Overall, really solid start on your design docs! Here are my notes so far: MVP LIST

[ ] Which features can a user use when logged out? What is restricted to being logged in?
[ ] Homepage (or splash page) will be part of auth, so you should remove this as its own MVP. When building this, you'll just neglect the lessons index at first, and then finishing building it out during the Lessons MVP.
[ ] Add production README as MVP 7

SCHEMA

[ ] Photos will be attached using activestorage which will build its own tables, so you can remove all foreign keys referencing photos
[ ] Will lessons be in categories (as they are on instructables)? If so, you'll need to add a table of categories and a foreign key on lessons to point to the categories table.

Chris6135 commented 4 years ago

Thanks Josh! For the photos, should I remove all reference to photo_id from my tables wholehog, or replace them with something like photo_url?

Other than that I've addressed the other issues.