search

Chris7 / Mudlet2

Mudlet vesion 2.+
GNU General Public License v2.0
3 stars 2 forks source link

Search speed with variables #23

Closed vadi2 closed 11 years ago

vadi2 commented 11 years ago

This is a bit of a tricky issue, but I think it is better to raise and face it earlier than later.

Adding variables to searching noticeably slowed down search. It's noticeable on my 3.6Ghz core computer - especially more when I clock it at the minimum 1.6Ghz it can do. Someone not playing on top-end gaming hardware as I do (DDR5 ram, i5 CPU) - on an old netbook, for example - will significantly suffer, and eventually enough complaints will happen that it'd trickle back to us that "search is slow".

The issue with searching isn't quite new - given certain queries, one can hang up the client already for a long while. For example, if you type in e accidentally on a full profile and search. Do that in the middle of intense real-time combat and you'd be fairly frustrated.

I'm not sure on the best way to address this yet - there are several - but raising the issue and investigating it is a step.

Chris7 commented 11 years ago

I put in a speed improvement for variable searching. Try it out now.

On Mon, Oct 14, 2013 at 6:09 PM, Vadim Peretokin notifications@github.comwrote:

This is a bit of a tricky issue, but I think it is better to raise and face it earlier than later.

Adding variables to searching noticeably slowed down search. It's noticeable on my 3.6Ghz core computer - especially more when I clock it at the minimum 1.6Ghz it can do. Someone not playing on top-end gaming hardware as I do (DDR5 ram, i5 CPU) - on an old netbook, for example - will significantly suffer, and eventually enough complaints will happen that it'd trickle back to us that "search is slow".

The issue with searching isn't quite new - given certain queries, one can hang up the client already for a long while. For example, if you type in eaccidentally on a full profile and search. Do that in the middle of intense real-time combat and you'd be fairly frustrated.

I'm not sure on the best way to address this yet - there are several - but raising the issue and investigating it is a step.

— Reply to this email directly or view it on GitHubhttps://github.com/Chris7/Mudlet2/issues/23 .

vadi2 commented 11 years ago

I think it feels better. Haven't got metrics. Thanks!