search

Chris7462 / kitti_to_ros2bag

Apache License 2.0
13 stars 2 forks source link

Fix small typo in rosdep key and update include header #4

Closed SkxPhan closed 1 week ago

SkxPhan commented 1 week ago

Hello 👋

Thank you for your repo, very useful!

While building the package on Jazzy, I noticed 2 issues:

  1. Couldn't find the header _cv_bridge/cvbridge.h but the build worked with _cv_bridge/cvbridge.hpp.
  2. Typo in the rosdep key _tf2_geometrymsgs in package.xml.

Feel free to merge this PR at your convenience!

Best regards.

Chris7462 commented 1 week ago

Currently, I don't plan to switch to Jazzy since there are still users for Foxy and Humble. Instead, you can just create a symbolic link named cv_bridge.h pointing to cv_bridge.hpp in the /opt/ros/jazzy/include/cv_bridge/cv_bridge/ folder, which will resolve this issue.