ChrisASearles / CompLinks

0 stars 0 forks source link

Functionality of Featured Stores containers to the right of hero image on home page #132

Closed robgpeak closed 7 years ago

robgpeak commented 7 years ago

I wanted to ensure the Featured Stores containers (image below), have the same functionality as the Featured Stores containers at the bottom of the home page, whereby a user clicking anywhere in the overall container EXCEPT the Show Now button, will take the user to the particular store index page, but if the user clicks the Shop Now button would start a shopping trip in a new browser tab.

This should be the same functionality in the Store Boxes.

uploads/b3794d08-e7a4-406f-8104-b23948c39aa4/Screen Shot 2017-05-24 at 9.41.04 AM.png

ChrisASearles commented 7 years ago

I believe the next time @cgladue pushes a new version up this should be taken care of.

cgladue commented 7 years ago

i just pushed it, but there are a lot of errors if you look in the Console, and the site dosnt look right to me, is something not included int he project correctly ?

cgladue commented 7 years ago

published

robgpeak commented 7 years ago

For the purpose of this specific issue of having the link from the overall box lead to the store, and the Shop Now button to actually start a trip, it is almost complete. The Shop Now buttons do NOT currently start a shopping trip in a new tab, and the URL that it is gong to does not exist. I think this was assigned to me pre-maturely.

ChrisASearles commented 7 years ago

@robgpeak It actually does but there are no default links defined for those advertisers and #117 is not yet complete. I'm going to close this issue as complete and will request an update on the status of #117

robgpeak commented 7 years ago

I just clicked on the Macy's Shop Now button, but the link is broken and does not work, yet there is a default link for Macy's. Additionally, it should pop open in a new tab but it does not.

ChrisASearles commented 7 years ago

New tab is fixed and waiting to be published, @cgladue can you look into the link issue? Front end is pulling the startTripLink.

cgladue commented 7 years ago

done